Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[train] New persistence mode: Tune tests + examples (small) (batch 1) #38807

Merged
merged 25 commits into from
Aug 25, 2023
Merged

[train] New persistence mode: Tune tests + examples (small) (batch 1) #38807

merged 25 commits into from
Aug 25, 2023

Conversation

justinvyu
Copy link
Contributor

@justinvyu justinvyu commented Aug 23, 2023 •
edited
Loading

Why are these changes needed?

This PR updates a bunch of Tune tests -- mostly tune controller execution tests.

Related issue number

#38570

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

justinvyu added 13 commits August 23, 2023 01:03
@justinvyu
test_tuner_restore
7e9e91b 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
test_actor_reuse
779d29c 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
test_actor_caching
0c38d87 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
test_cluster_searcher kind of working
bb75a23 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
remove test_cluster_searcher
6813cc9 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
test_controller_callback_integration
b0c1c00 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
fix lint
a0e60d0 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
test_controller_control_integration
823e5d7 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
test_controller_errors_integration
1502be3 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
test_controller_control_integration
cff6c4b 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
test_controller_search_alg_integration
67c0e87 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
fix lint
9d09ace 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
Merge branch 'master' of https://github.com/ray-project/ray into air/…
9c6800c 
…persistence/ci/tune1
@justinvyu justinvyu requested review from ericl and krfricke August 23, 2023 23:04
justinvyu
justinvyu commented Aug 23, 2023
View reviewed changes
python/ray/tune/BUILD
@@ -94,15 +94,6 @@ py_test(
tags = ["team:ml", "exclusive", "rllib"],
)

py_test(
name = "test_cluster_searcher",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is pretty much replaced by test_experiment_restore. The test setup was strange and hard to fix.

@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Aug 24, 2023
@justinvyu
create mock storage dirs
57d0d7e 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
move test_tuner_restore to new runner
c926bcf 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
Merge branch 'master' of https://github.com/ray-project/ray into air/…
4690ffa 
…persistence/ci/tune1
@justinvyu
Merge branch 'master' of https://github.com/ray-project/ray into air/…
32990ec 
…persistence/ci/tune1
@justinvyu
add conftest
811b75b 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
Merge branch 'master' of https://github.com/ray-project/ray into air/…
edb1de5 
…persistence/ci/tune1

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
fix missing local dir in controller tests
1e2c0b5 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
return storage
7303aba 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
Merge branch 'master' of https://github.com/ray-project/ray into air/…
a73ed22 
…persistence/ci/tune1

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
unsaved file
8268638 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
fix merge conflict logic
2c63559 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
fix lint
79cf402 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu justinvyu added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels Aug 25, 2023
zhe-thoughts
zhe-thoughts approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary Train change for 2.7

@zhe-thoughts zhe-thoughts merged commit d53e300 into ray-project:master Aug 25, 2023
@justinvyu justinvyu deleted the air/persistence/ci/tune1 branch August 25, 2023 20:18
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@justinvyu @arvind-chandra
[train] New persistence mode: Tune tests + examples (small) (batch …
da192cb 
…1) (ray-project#38807)

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
LeonLuttenberger pushed a commit to jaidisido/ray that referenced this pull request Sep 5, 2023
@justinvyu @LeonLuttenberger
[train] New persistence mode: Tune tests + examples (small) (batch …
d1f842e 
…1) (ray-project#38807)

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
jimthompson5802 pushed a commit to jimthompson5802/ray that referenced this pull request Sep 12, 2023
@justinvyu @jimthompson5802
[train] New persistence mode: Tune tests + examples (small) (batch …
4a71955 
…1) (ray-project#38807)

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@justinvyu
[train] New persistence mode: Tune tests + examples (small) (batch …
641e3e0 
…1) (ray-project#38807)

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

@zhe-thoughts zhe-thoughts zhe-thoughts approved these changes

@krfricke krfricke Awaiting requested review from krfricke

Assignees

@ericl ericl

@zhe-thoughts zhe-thoughts

@krfricke krfricke

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justinvyu @ericl @zhe-thoughts @krfricke