Remove grpcio from minimal dependency #38243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add grpc deps to default and remove from minimal add DrainNode to python gcs_client, and remove grpc from autoscaler.py Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
rynewang
requested review from
richardliaw,
ericl,
edoakes,
a team,
wuisawesome and
DmitriGekhtman
as code owners
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
edoakes
approved these changes
Aug 9, 2023
…nt optional Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
…le tests Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
pcmoritz
reviewed
Aug 10, 2023
pcmoritz
approved these changes
Aug 10, 2023
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
pcmoritz
approved these changes
Aug 12, 2023
rkooo567
approved these changes
Aug 12, 2023
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
…nit tests. Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
|
Failed tests seem unrelated |
|
(Also, let's make sure to mention this to the release note. Please track the changes so that we can record them!) |
|
Looks like we need a doc approval. cc @angelinalg can you give us an approval? |
pcmoritz
added a commit
to pcmoritz/ray-1
that referenced
this pull request
Aug 15, 2023
This reverts commit ef2a040. Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
pcmoritz
added a commit
that referenced
this pull request
Aug 15, 2023
rynewang
added a commit
that referenced
this pull request
Aug 15, 2023
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
Removes grpcio from ray dependency while adds it to ray[default] dependency. Removed use of grpc client: gcs_node_info_stub.DrainNode in autoscaler. Moved it into raylet.pyx. Removed use of grpc client: gcs_node_resources_stub.GetAllResourceUsage in autoscaler. Moved it into raylet.pyx. Removed use of grpc status code. Moved it into raylet.pyx. Removed Ray Client tests in test_runtime_env_ray_minimal.py --------- Signed-off-by: Ruiyang Wang <rywang014@gmail.com> Signed-off-by: NripeshN <nn2012@hw.ac.uk>
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
…ay-project#38453) This reverts commit ef2a040. Signed-off-by: NripeshN <nn2012@hw.ac.uk>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Removes grpcio from ray dependency while adds it to ray[default] dependency. Removed use of grpc client: gcs_node_info_stub.DrainNode in autoscaler. Moved it into raylet.pyx. Removed use of grpc client: gcs_node_resources_stub.GetAllResourceUsage in autoscaler. Moved it into raylet.pyx. Removed use of grpc status code. Moved it into raylet.pyx. Removed Ray Client tests in test_runtime_env_ray_minimal.py --------- Signed-off-by: Ruiyang Wang <rywang014@gmail.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…ay-project#38453) This reverts commit ef2a040. Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
5 tasks
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
Removes grpcio from ray dependency while adds it to ray[default] dependency. Removed use of grpc client: gcs_node_info_stub.DrainNode in autoscaler. Moved it into raylet.pyx. Removed use of grpc client: gcs_node_resources_stub.GetAllResourceUsage in autoscaler. Moved it into raylet.pyx. Removed use of grpc status code. Moved it into raylet.pyx. Removed Ray Client tests in test_runtime_env_ray_minimal.py --------- Signed-off-by: Ruiyang Wang <rywang014@gmail.com> Signed-off-by: Victor <vctr.y.m@example.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…ay-project#38453) This reverts commit ef2a040. Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes grpcio from
raydependency while adds it toray[default]dependency.Removed use of grpc client:
gcs_node_info_stub.DrainNodein autoscaler. Moved it intoraylet.pyx.Removed use of grpc client:
gcs_node_resources_stub.GetAllResourceUsagein autoscaler. Moved it intoraylet.pyx.Removed use of grpc status code. Moved it into
raylet.pyx.Removed Ray Client tests in
test_runtime_env_ray_minimal.py