Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update arrow to include https://github.com/apache/arrow/pull/3392 #3765

Merged
merged 3 commits into from
Jan 14, 2019
Merged

Update arrow to include https://github.com/apache/arrow/pull/3392 #3765

merged 3 commits into from
Jan 14, 2019

Conversation

pcmoritz
Copy link
Contributor

This is needed for #3734

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10829/
Test FAILed.

guoyuhong
guoyuhong requested changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@guoyuhong guoyuhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change. I left one comment.

cmake/Modules/ArrowExternalProject.cmake
@@ -25,7 +25,7 @@ set(arrow_URL https://github.com/ray-project/arrow.git)
# WARNING: If the arrow version is updated, you need to also update the
# SETUPTOOLS_SCM_PRETEND_VERSION version string in the ThirdpartyToolchain.cmake
# file
set(arrow_TAG c347cd571e51723fc8512922f1b3a8e45e45b169)
set(arrow_TAG f8c990e4165012123e03d822c95526eaea5cbfab)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 23 with # https://github.com/ray-project/arrow/commit/c347cd571e51723fc8512922f1b3a8e45e45b169 should also be changed, right? Is there a time line to merge apache/arrow#3177 , current status seems very inconvenient.

Copy link
Contributor Author

@pcmoritz pcmoritz Jan 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I changed the link to the patch (originally I didn't because it's the same changes, but could be confusing I agree).

As for an upstream fix, I don't think it will happen any time soon. Also pytorch/tensorflow won't be fixed any time soon, see the discussion (they essentially can't do it on their own I think). It's really annoying, but there is not much we can do about it. The arguments from all sides make a lot of sense to me, probably what actually needs to happen is people need either to switch away from pip to conda, or nvidia needs to make sure that cuda is compatible with manylinux1 (or manylinux2010 in the future) to really fix this for everybody (I assume you followed the discussion in that issue and the mailing list).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10831/
Test FAILed.

guoyuhong
guoyuhong approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@guoyuhong guoyuhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will merge it once the CI passes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10832/
Test PASSed.

@guoyuhong guoyuhong merged commit 02bdaf2 into ray-project:master Jan 14, 2019
suquark added a commit to suquark/ray that referenced this pull request Jan 14, 2019
@suquark
revert changes to "id.h" because ray-project#3765 has been merged.
645c3f8
@robertnishihara robertnishihara mentioned this pull request Jan 14, 2019
Closed
pcmoritz pushed a commit that referenced this pull request Jan 18, 2019
@suquark @pcmoritz
Get rid of Arrow test utils (#3734)
16a3b99 
* convert code to proper C++

* revert changes to "id.h" because #3765 has been merged.

* revert changes to Python bindings because they will be removed in #3541

* remove dependencies of Arrow logging

* revert changes to Arrow logging

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoyuhong guoyuhong guoyuhong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcmoritz @AmplabJenkins @guoyuhong