-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Support to auto-generate Java files from flatbuffer #3749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test FAILed. |
Test FAILed. |
Test PASSed. |
const flatbuffers::String &string) { | ||
const auto &object_ids = string_from_flatbuf(string); | ||
std::vector<ray::ObjectID> ret; | ||
auto count = object_ids.size() / kUniqueIDSize; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also do RAY_CHECK(object_ids.size() % kUniqueIDSize == 0);
Test PASSed. |
@jovany-wang There is another linting error:
|
Test PASSed. |
What do these changes do?
For supporting this, we change the fields in
gcs.fbs
:change
[string]
to onestring
that concatenates the array of strings.Also, there is a script to support to add a package declarations to auto-generated files. (We should find another approach for this in the future.)
This is the related PR.
Related issue number
N/A