Skip to content

Support to auto-generate Java files from flatbuffer #3749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jan 13, 2019

Conversation

jovany-wang
Copy link
Contributor

@jovany-wang jovany-wang commented Jan 11, 2019

What do these changes do?

For supporting this, we change the fields in gcs.fbs:
change [string] to one string that concatenates the array of strings.

Also, there is a script to support to add a package declarations to auto-generated files. (We should find another approach for this in the future.)

This is the related PR.

Related issue number

N/A

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10773/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10774/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10775/
Test PASSed.

const flatbuffers::String &string) {
const auto &object_ids = string_from_flatbuf(string);
std::vector<ray::ObjectID> ret;
auto count = object_ids.size() / kUniqueIDSize;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also do RAY_CHECK(object_ids.size() % kUniqueIDSize == 0);

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10785/
Test PASSed.

@pcmoritz
Copy link
Contributor

@jovany-wang There is another linting error:

15.09s$ flake8 --exclude=python/ray/core/generated/,doc/source/conf.py,python/ray/cloudpickle/ --ignore=C408,E121,E123,E126,E226,E24,E704,W503,W504,W605
./java/modify_generated_java_flatbuffers_files.py:9:80: E501 line too long (85 > 79 characters)
./java/modify_generated_java_flatbuffers_files.py:11:80: E501 line too long (80 > 79 characters)
The command "flake8 --exclude=python/ray/core/generated/,doc/source/conf.py,python/ray/cloudpickle/ --ignore=C408,E121,E123,E126,E226,E24,E704,W503,W504,W605" exited with 1.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10818/
Test PASSed.

@pcmoritz pcmoritz merged commit 8674606 into ray-project:master Jan 13, 2019
@jovany-wang jovany-wang deleted the auto-gen-java-fbs-2 branch January 17, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants