Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint for KubeRay NodeProvider #37020

Merged
merged 1 commit into from
Jul 2, 2023
Merged

Fix lint for KubeRay NodeProvider #37020

merged 1 commit into from
Jul 2, 2023

Conversation

pcmoritz
Copy link
Contributor

@pcmoritz pcmoritz commented Jul 1, 2023

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@pcmoritz pcmoritz requested review from wuisawesome, DmitriGekhtman, ericl and a team as code owners July 1, 2023 06:09
@pcmoritz pcmoritz merged commit 7f1ffb9 into ray-project:master Jul 2, 2023
@aslonnie aslonnie mentioned this pull request Jul 2, 2023
Closed
bveeramani pushed a commit to bveeramani/ray that referenced this pull request Jul 5, 2023
@pcmoritz @bveeramani
Fix lint for KubeRay NodeProvider (ray-project#37020)
b5e9ceb 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani mentioned this pull request Jul 5, 2023
Merged
bveeramani added a commit that referenced this pull request Jul 5, 2023
@bveeramani @pcmoritz
Fix lint for KubeRay NodeProvider (#37020) (#37125)
7616ec8 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Co-authored-by: Philipp Moritz <pcmoritz@gmail.com>
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@pcmoritz @arvind-chandra
Fix lint for KubeRay NodeProvider (ray-project#37020)
b82929e 
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriGekhtman DmitriGekhtman DmitriGekhtman approved these changes

@gvspraveen gvspraveen gvspraveen approved these changes

@wuisawesome wuisawesome Awaiting requested review from wuisawesome

@ericl ericl Awaiting requested review from ericl

Assignees

@ericl ericl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pcmoritz @gvspraveen @DmitriGekhtman @ericl