[Java] Support calling Ray APIs from multiple threads #3646
Conversation
jovany-wang
changed the title
| int arg = random.nextInt(); | ||
| RayObject<Integer> obj = Ray.put(arg); | ||
| Assert.assertEquals(arg, (int) Ray.get(obj.getId())); | ||
| }); |
There was a problem hiding this comment.
Let's also add a test case of calling Ray.wait here.
jovany-wang
force-pushed
the
java-threading-sync
branch
from
83ae2b2 to
9fc839a
Compare
|
Test PASSed. |
| currentClassLoader = null; | ||
| currentTask = createDummyTask(workerMode, driverId); | ||
| mainThreadId = Thread.currentThread().getId(); | ||
| multiThreadingWarned = new AtomicBoolean(); |
There was a problem hiding this comment.
nit, set default value to false
raulchen
left a comment
raulchen
left a comment
There was a problem hiding this comment.
LGTM except one small comment.
|
Test FAILed. |
raulchen
changed the title
|
Test FAILed. |
|
Test FAILed. |
| workerId = workerMode == WorkerMode.DRIVER ? driverId : UniqueId.randomId(); | ||
| currentTaskPutCount = 0; | ||
| currentTaskCallCount = 0; | ||
| currentTaskPutCount = new AtomicInteger(0); |
There was a problem hiding this comment.
Should these also be reset to 0 in setCurrentTask?
| public void setCurrentTask(TaskSpec currentTask) { | ||
| this.currentTask = currentTask; | ||
| currentTaskCallCount.set(0); | ||
| currentTaskCallCount.set(0); |
|
Test FAILed. |
|
Test FAILed. |
4 participants
What do these changes do?
We do these things for supporting this:
currentTaskPutCountandcurrentTaskCallCountas atomic variables.objectStoreas thread local.currentThreadTaskIds in different threads.Btw, the implementation of
getCurrentThreadTaskId()is quoted from @kfstorm, thanks.Related issue number
N/A