New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in PyRayletCient #3640

Merged

robertnishihara merged 1 commit into ray-project:master from antgroup:fix_mem_leak

Dec 28, 2018

Contributor

raulchen commented Dec 26, 2018

if using PyObject_GetIter, the caller must call Py_DECREF to avoid memory leak. But with PyList_GetItem, Py_DECREF isn't needed.
the Py_BuildValue call in wait doesn't need to increment ref count.


          Fix memory leak in PyRayletCient

eba0cf2

AmplabJenkins commented Dec 26, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10417/
Test PASSed.

robertnishihara approved these changes

View reviewed changes

robertnishihara merged commit 0b682d0 into ray-project:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet