Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new boost libs failure in cache-lib mode and add test to cover collect_dependent_libs.sh #3627

Merged
merged 3 commits into from
Jan 3, 2019

Conversation

guoyuhong
Copy link
Contributor

@guoyuhong guoyuhong commented Dec 24, 2018

What do these changes do?

This PR #3574 breaks the script that builds ray using cached libs.
This PR does the following things:

  1. Fix the building failure introduced by Fix TensorFlow and PyTorch compatibility #3574 .
    • The cached boost lib does not realize there are version mismatch, so this PR add a version check. If there is version mismatch, correct boost will be downloaded and built.
    • The cached boost lib does not contain the new Boost::Thread lib.
  2. Add a test to cover collect_dependent_libs.sh and cover the build-with-cache-lib mode.

Related issue number

#3521

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10360/
Test FAILed.

@guoyuhong
Copy link
Contributor Author

The valgrind test time grows from about 18 minutes to around 24 minutes.

@guoyuhong
Copy link
Contributor Author

@pcmoritz Please take a look when you are spared.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10414/
Test PASSed.

@guoyuhong
Copy link
Contributor Author

@robertnishihara Do you have any comments on this PR?

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10543/
Test FAILed.

@pcmoritz pcmoritz merged commit ad2287e into ray-project:master Jan 3, 2019
@guoyuhong guoyuhong deleted the fixNewBoostLibs branch January 25, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants