[rllib] Allow development without needing to compile Ray #3623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardliaw
reviewed
Dec 24, 2018
python/ray/rllib/setup-rllib-dev.py
Outdated
| local_home = os.path.abspath(os.path.dirname(__file__)) | ||
| assert os.path.isdir(rllib_home), rllib_home | ||
| assert os.path.isdir(local_home), local_home | ||
| print( |
There was a problem hiding this comment.
click.confirm(msg, abort=True)?
|
Test FAILed. |
richardliaw
approved these changes
Dec 24, 2018
|
Lgtm |
| @@ -17,10 +17,6 @@ Trying snapshots from master | |||
|
|
|||
| Here are links to the latest wheels (which are built off of master). To install these wheels, run the following command: | |||
|
|
|||
| .. danger:: | |||
|
|
|||
| These versions will have newer features but are subject to more bugs. If you encounter crashes or other instabilities, please revert to the latest stable version. | |||
There was a problem hiding this comment.
Why remove this warning?
|
So the idea is that you would |
|
I believe the warning is outdated now that x-ray is stable, though we can
keep it if you prefer.
And yeah, the idea is to avoid compilation entirely for rllib dev.
…On Mon, Dec 24, 2018, 3:57 PM Robert Nishihara ***@***.***> wrote:
So the idea is that you would pip install ray but then use rllib from the
cloned repo?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3623 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAA6SjSxNAsBkZax8YEYxnsyZ9JzaRlUks5u8HrxgaJpZM4ZgEYW>
.
|
|
Ok sounds good. I'm fine with removing the warning. |
|
Test FAILed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a script that sets up symlinks between the rllib git dir and the installed source. Not perfect, but makes it so you don't need to compile Ray if just editing rllib source.
Closes #3608