Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] resources_per_trial from trial_resources #3580

Merged
merged 5 commits into from
Dec 21, 2018
Merged

[tune] resources_per_trial from trial_resources #3580

merged 5 commits into from
Dec 21, 2018

Conversation

richardliaw
Copy link
Contributor

Renaming variable due to user errors.

@richardliaw richardliaw requested a review from ericl December 20, 2018 06:28
@richardliaw
Copy link
Contributor Author

@visatish please review, thanks

ericl
ericl reviewed Dec 20, 2018
View reviewed changes
Copy link
Contributor

@ericl ericl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we make it logger.warn and raise later?

@richardliaw
Copy link
Contributor Author

Done

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10198/
Test FAILed.

ericl
ericl reviewed Dec 20, 2018
View reviewed changes
python/ray/tune/config_parser.py
if "trial_resources" in spec:
trial_kwargs["resources"] = json_to_resources(spec["trial_resources"])
if "resources_per_trial" in spec:
trial_kwargs["resources"] = json_to_resources(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this actually parse the old value right? Can you add a test that using the old value is fine?

Copy link
Contributor Author

@richardliaw richardliaw Dec 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

er the old value is just dropped and replaced with this value early on; sure will add test

@visatish
Copy link
Contributor

@richardliaw this looks good

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10204/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10211/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10220/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10221/
Test FAILed.

@richardliaw richardliaw merged commit e046a5c into ray-project:master Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richardliaw @AmplabJenkins @visatish @ericl