Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rllib] support running older version tensorflow(version < 1.5.0) #3571

Merged
merged 3 commits into from
Dec 20, 2018

Conversation

adoda
Copy link
Contributor

@adoda adoda commented Dec 18, 2018

support run rllib's examples with older version tensorflow(version < 1.5.0)

What do these changes do?

support run the rllib's examples with tensorflow (version < 1.5.0)

  • tf.boolean_mask only support tf.bool when tf version < 1.5.0

  • tf.variable_scope support auxiliary_name_scope when tf version >= 1.5.0

Related issue number

#3570

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10124/
Test PASSed.

Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't clutter the example but the rest of changes look fine to me

@richardliaw richardliaw changed the title support run rllib's examples with older version tensorflow(version < 1.5.0) [rllib] support running older version tensorflow(version < 1.5.0) Dec 18, 2018
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10157/
Test FAILed.

@adoda
Copy link
Contributor Author

adoda commented Dec 19, 2018

@richardliaw updated

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10158/
Test FAILed.

@adoda
Copy link
Contributor Author

adoda commented Dec 19, 2018

jenkins, retest this please

@adoda
Copy link
Contributor Author

adoda commented Dec 19, 2018

unrelated error @richardliaw

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10170/
Test FAILed.

@adoda
Copy link
Contributor Author

adoda commented Dec 20, 2018

Could anybody help for this commit? @ericl @richardliaw

@richardliaw
Copy link
Contributor

Test failures look unrelated - sorry for the delay!

@richardliaw richardliaw merged commit cf0c474 into ray-project:master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants