Removing the check about the size re: ray-project/ray#3450 #3464
Conversation
|
Please don't merge this. If this happens it is almost always an error. If we want to allow this then we need to make it's only happening in the case where the user passed in the object store memory and we need to provide a very scary warning. |
|
I guess we should decide whether users should be responsible for the results of specifying I do not think raising a scary warning would be helpful to Modin. Printing the same information that was previously printed would be good enough for our purposes. |
|
I think the right thing to do here is to compare the object_store_memory with the size of the plasma_directory (for /tmp it would be the size of the disk, for /dev/shm it would be the size of the shared memory pool) |
|
Test FAILed. |
|
Updated PR given previous comments. It is not possible to verify the size of the device that is mounted for the I moved the check inside the condition |
|
Test FAILed. |
| @@ -1028,9 +1028,6 @@ def determine_plasma_store_config(object_store_memory=None, | |||
| "when calling ray.init() or ray start.") | |||
| object_store_memory = MAX_DEFAULT_MEM | |||
|
|
|||
| if plasma_directory is not None: | |||
| plasma_directory = os.path.abspath(plasma_directory) | |||
There was a problem hiding this comment.
Ok, I see you just moved it.
|
Test FAILed. |
|
jenkins retest this please |
|
Test FAILed. |
I have opened this in the interest of continuing the discussion here.
What do these changes do?
Removes the check causing #3450
This is important in Modin specifically to allow us to use the disk for plasma.
Related issue number
Resolves #3450