Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] Deprecate ambiguous function values (use tune.function / tune.sample_from instead) #3457

Merged
merged 2 commits into from
Dec 6, 2018
Merged

[tune] Deprecate ambiguous function values (use tune.function / tune.sample_from instead) #3457

merged 2 commits into from
Dec 6, 2018

Conversation

ericl
Copy link
Contributor

@ericl ericl commented Dec 3, 2018

What do these changes do?

In RLlib especially, it is very confusing when passing functions to Tune that get auto-expanded at variant generation time. Add a warning about this.

In a future release, we can consider changing the warning to an error.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9704/
Test FAILed.

@ericl
Copy link
Contributor Author

ericl commented Dec 3, 2018

jenkins retest this please

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9711/
Test FAILed.

@ericl
Copy link
Contributor Author

ericl commented Dec 4, 2018

jenkins retest this please

@ericl ericl added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Dec 4, 2018
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9726/
Test FAILed.

@ericl ericl merged commit 412aaa5 into ray-project:master Dec 6, 2018
@justusschock justusschock mentioned this pull request Dec 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees

@richardliaw richardliaw

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericl @AmplabJenkins @richardliaw