Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ray stack tool for debugging #3213

Merged
merged 8 commits into from
Nov 3, 2018
Merged

Add ray stack tool for debugging #3213

merged 8 commits into from
Nov 3, 2018

Conversation

ericl
Copy link
Contributor

@ericl ericl commented Nov 2, 2018

What do these changes do?

Adds a command that dumps all worker stack traces on the current node.

robertnishihara
robertnishihara reviewed Nov 2, 2018
View reviewed changes
python/ray/scripts/scripts.py
fi
export IFS="
"
sudo true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this sudo for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit confusing to have it show up later after we already print some stuff out so I do it right away.

robertnishihara
robertnishihara reviewed Nov 2, 2018
View reviewed changes
python/ray/scripts/scripts.py
echo "ERROR: Please 'pip install py-spy' first"
exit 1
fi
export IFS="
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It lets you iterate over the lines by line instead of by word.

robertnishihara
robertnishihara reviewed Nov 2, 2018
View reviewed changes
Copy link
Collaborator

@robertnishihara robertnishihara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. I just tried this and it worked (MacOS).

@robertnishihara
Copy link
Collaborator

@ericl I added a test, please take a look.

Not 100% sure it will pass in Travis due to the sudo usage, but we'll see.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9015/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9016/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9017/
Test PASSed.

@ericl ericl mentioned this pull request Nov 3, 2018
Closed
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9019/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9021/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9020/
Test PASSed.

@robertnishihara robertnishihara merged commit 9a0f0db into ray-project:master Nov 3, 2018
@robertnishihara robertnishihara deleted the stack branch November 3, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertnishihara robertnishihara robertnishihara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericl @robertnishihara @AmplabJenkins