terminate photon task dispatch early when workers or resources are unavailable #311
Conversation
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
src/photon/photon_algorithm.c
Outdated
| } | ||
| return; /* No workers available -- terminate early. */ | ||
| } | ||
| /* Terminate early if there are no more resources available. */ |
There was a problem hiding this comment.
This assumes that all tasks consume resources, e.g., that we can't do
@ray.remote(num_cpus=0, num_gpus=0)
which is probably fine.
There was a problem hiding this comment.
yeah, that's right. I assume that a task must consume some resources, even if it's a fraction of a core.
src/photon/photon_algorithm.c
Outdated
| } | ||
| } | ||
| if (!resources_available) { | ||
| return; /* No resources available -- terminate early. */ |
There was a problem hiding this comment.
This comment should be on the preceding line. Same with line 584.
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
No description provided.