Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Add more codeowners for Preprocessors #30367

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Nov 16, 2022

Signed-off-by: amogkam amogkamsetty@yahoo.com

Currently, @clarkzinzow is the only data codeowner with context on preprocessors. This PR adds more codeowners for the ray/data/preprocessors directory.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Copy link
Contributor

@clarkzinzow clarkzinzow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@amogkam amogkam merged commit dcad1a8 into ray-project:master Nov 16, 2022
@amogkam amogkam deleted the preprocessor-code-owners branch November 16, 2022 22:41
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
Signed-off-by: amogkam amogkamsetty@yahoo.com

Currently, @clarkzinzow is the only data codeowner with context on preprocessors. This PR adds more codeowners for the ray/data/preprocessors directory.

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
amogkam added a commit that referenced this pull request Jan 4, 2023
Signed-off-by: amogkam amogkamsetty@yahoo.com

Additional codeowners were added to ray/data/preprocessors package in #30367.

This is a followup to add the same codeowners for preprocessors tests as well.
AmeerHajAli pushed a commit that referenced this pull request Jan 12, 2023
Signed-off-by: amogkam amogkamsetty@yahoo.com

Additional codeowners were added to ray/data/preprocessors package in #30367.

This is a followup to add the same codeowners for preprocessors tests as well.
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
Signed-off-by: amogkam amogkamsetty@yahoo.com

Additional codeowners were added to ray/data/preprocessors package in ray-project#30367.

This is a followup to add the same codeowners for preprocessors tests as well.

Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants