Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password authentication to Redis ports #2952

Merged
merged 27 commits into from
Oct 17, 2018
+462 −115
Merged

Add password authentication to Redis ports #2952

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
5cb5af8
Implement Redis authentication
pschafhalter Sep 24, 2018
e6c669e
Throw exception for legacy Ray
pschafhalter Sep 25, 2018
772cff0
Add test
pschafhalter Sep 25, 2018
fde3c16
Formatting
pschafhalter Sep 25, 2018
e1fe5dd
Fix bugs in CLI
pschafhalter Sep 25, 2018
053ae44
Fix bugs in Raylet
pschafhalter Sep 25, 2018
ce24f42
Move default password to constants.h
pschafhalter Sep 26, 2018
8cac24b
Use pytest.fixture
pschafhalter Sep 26, 2018
386d69b
Fix bug
pschafhalter Oct 3, 2018
901e8b4
Authenticate using formatted strings
pschafhalter Oct 3, 2018
ef62552
Add missing passwords
pschafhalter Oct 6, 2018
9291512
Add test
pschafhalter Oct 6, 2018
2b41641
Improve authentication of async contexts
pschafhalter Oct 10, 2018
0e6609e
Disable Redis authentication for credis
pschafhalter Oct 10, 2018
1be3105
Update test for credis
pschafhalter Oct 10, 2018
7200454
Fix rebase artifacts
pschafhalter Oct 10, 2018
bc514fd
Fix formatting
pschafhalter Oct 12, 2018
15edd1d
Add workaround for issue #3045
pschafhalter Oct 12, 2018
9f3434a
Increase timeout for test
pschafhalter Oct 13, 2018
1c079a1
Improve C++ readability
pschafhalter Oct 13, 2018
56f3225
Fixes for CLI
pschafhalter Oct 15, 2018
17bc360
Add security docs
pschafhalter Oct 16, 2018
d13edca
Address comments
pschafhalter Oct 16, 2018
6944814
Address comments
pschafhalter Oct 16, 2018
8e090fe
Adress comments
pschafhalter Oct 16, 2018
00c045f
Use ray.get
pschafhalter Oct 16, 2018
f3d68e2
Fix lint
pschafhalter Oct 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adress comments
  • Loading branch information
@pschafhalter
pschafhalter committed Oct 16, 2018
commit 8e090fe99a4a9795e2001185f3aad43c9cc944c2
4 changes: 2 additions & 2 deletions python/ray/test/test_ray_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ def f():
redis_ip, redis_port = redis_address.split(":")

# Check that we can run a task
task_id = f.remote()
ready, running = ray.wait([task_id], timeout=5000)
object_id = f.remote()
ready, running = ray.wait([object_id], timeout=5000)
assert len(ready) > 0, "Expected task to complete"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of a nit, but task_id should be object_id.

Also, instead of doing wait followed by an assert, maybe just do ray.get(object_id).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind if I keep the ray.wait? While testing, I ran into a case where ray.get wouldn't fail, but block indefinitely (I think this was when I discovered the issues with the new GCS).


# Check that Redis connections require a password
Expand Down