Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix name error in serve run ... example #29038

Merged
merged 2 commits into from
Oct 4, 2022
Merged

fix name error in serve run ... example #29038

merged 2 commits into from
Oct 4, 2022

Conversation

artemisart
Copy link
Contributor

@artemisart artemisart commented Oct 4, 2022 •
edited
Loading

Signed-off-by: Mathis Chenuet 9201969+artemisart@users.noreply.github.com

Why are these changes needed?

The documentation has wrong examples for serve run that fail because it should be the name of the variable and not the class.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@artemisart
fix name error in serve run ... example
80263b8 
Signed-off-by: Mathis Chenuet <9201969+artemisart@users.noreply.github.com>
simon-mo
simon-mo approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching it!

@architkulkarni
Copy link
Contributor

Windows test_client flaky on master
Windows serve:test_api timeout unrelated (this PR contains only markdown changes)

@architkulkarni architkulkarni added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Oct 4, 2022
@architkulkarni architkulkarni merged commit 419dd8d into ray-project:master Oct 4, 2022
@artemisart artemisart deleted the patch-1 branch October 5, 2022 13:55
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@artemisart @WeichenXu123
fix name error in serve run ... example (ray-project#29038)
2eae39a 
The documentation has wrong examples for serve run that fail because it should be the name of the variable and not the class.

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sihanwang41 sihanwang41 sihanwang41 approved these changes

@simon-mo simon-mo simon-mo approved these changes

@shrekris-anyscale shrekris-anyscale shrekris-anyscale approved these changes

@edoakes edoakes Awaiting requested review from edoakes edoakes is a code owner

@jiaodong jiaodong Awaiting requested review from jiaodong

Assignees

@architkulkarni architkulkarni

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@artemisart @architkulkarni @sihanwang41 @simon-mo @shrekris-anyscale