Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_illegal_put failure in plasma test. #289

Merged
merged 2 commits into from
Feb 17, 2017
Merged

Fix test_illegal_put failure in plasma test. #289

merged 2 commits into from
Feb 17, 2017

Conversation

robertnishihara
Copy link
Collaborator

In this test, client1 and client2 are connected to manager1 and manager2 respectively. We call client1 calls create and seal on an object. Then client2 calls create and seal on a slightly different object with the same object ID. This should cause a hash mismatch followed by a fatal error. We then check that the plasma manager died. However, in many instances on Travis, this check failed even though we could see the fatal error in the logs.

I think the issue is that manager1 was actually the one dying in a bunch of cases, meaning that the timing was such that the RAY.OBJECT_TABLE_ADD command for the second manager arrived at Redis first. This seems pretty unlikely, but I guess it can happen.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/40/
Test PASSed.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/41/
Test PASSed.

@stephanie-wang stephanie-wang merged commit 0bbf08a into ray-project:master Feb 17, 2017
@robertnishihara robertnishihara deleted the illegalput branch February 17, 2017 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants