Fix test_illegal_put failure in plasma test. #289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this test,
client1
andclient2
are connected tomanager1
andmanager2
respectively. We callclient1
callscreate
andseal
on an object. Thenclient2
callscreate
andseal
on a slightly different object with the same object ID. This should cause a hash mismatch followed by a fatal error. We then check that the plasma manager died. However, in many instances on Travis, this check failed even though we could see the fatal error in the logs.I think the issue is that
manager1
was actually the one dying in a bunch of cases, meaning that the timing was such that theRAY.OBJECT_TABLE_ADD
command for the second manager arrived at Redis first. This seems pretty unlikely, but I guess it can happen.