-
Couldn't load subscription status.
- Fork 6.8k
[rllib] Parallel-data loading and multi-gpu support for IMPALA #2766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test FAILed. |
|
Test FAILed. |
|
Test FAILed. |
|
Test FAILed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I think the multi-GPU stuff is too messy and we should move away from it. However it's not clear what the best way to do that is, perhaps with TF eager, or moving a lot of the logic into numpy, it would be simpler.
| return Resources( | ||
| cpu=1, | ||
| gpu=cf["gpu"] and cf["gpu_fraction"] or 0, | ||
| gpu=cf["num_gpus"] and cf["num_gpus"] * cf["gpu_fraction"] or 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what will happen if gpu_fraction > 1, but for < 1 I believe it should work.
It would be good to figure this out. Sphinx doesn't seem to have a good way to do this, unless you duplicate the comments in the dict, or change it to a class or something. For now I think it's reasonable to expect users to read the code since it's at the top of the file. |
|
Test FAILed. |
|
Test FAILed. |
|
Test FAILed. |
|
I just did a quick multi-GPU run on PPO / IMPALA atari and perf looks good still. |
|
Test FAILed. |
|
Test FAILed. |
|
Test FAILed. |
|
Test FAILed. |
|
Test FAILed. |
|
Test FAILed. |
|
Test FAILed. |
|
Test PASSed. |
What do these changes do?
Related issue number