Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade arrow to include more detailed flushing message #2706

Merged
merged 8 commits into from
Aug 24, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,9 @@ make -j${PARALLEL}
popd

# Move stuff from Arrow to Ray.
cp $ROOT_DIR/thirdparty/pkg/arrow/cpp/build/cpp-install/bin/plasma_store $BUILD_DIR/src/plasma/
cp $ROOT_DIR/thirdparty/pkg/arrow/cpp/build/cpp-install/bin/plasma_store_server $BUILD_DIR/src/plasma/
if [[ "$RAY_BUILD_PYTHON" == "YES" ]]; then
cp $ROOT_DIR/thirdparty/pkg/arrow/cpp/build/cpp-install/bin/plasma_store $BUILD_DIR/../python/ray/core/src/plasma/
cp $ROOT_DIR/thirdparty/pkg/arrow/cpp/build/cpp-install/bin/plasma_store_server $BUILD_DIR/../python/ray/core/src/plasma/
fi
if [[ "$RAY_BUILD_JAVA" == "YES" ]]; then
cp $ROOT_DIR/thirdparty/build/arrow/cpp/build/release/libplasma_java.* $BUILD_DIR/src/plasma/
Expand Down
2 changes: 1 addition & 1 deletion java/cleanup.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
pkill -9 python
pkill -9 local_scheduler
pkill -9 plasma_manager
pkill -9 plasma_store
pkill -9 plasma_store_server
pkill -9 global_scheduler
pkill -9 redis-server
pkill -9 redis
Expand Down
2 changes: 1 addition & 1 deletion java/prepare.sh
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ fi

declare -a nativeBinaries=(
"./src/common/thirdparty/redis/src/redis-server"
"./src/plasma/plasma_store"
"./src/plasma/plasma_store_server"
"./src/plasma/plasma_manager"
"./src/local_scheduler/local_scheduler"
"./src/global_scheduler/global_scheduler"
Expand Down
7 changes: 3 additions & 4 deletions java/ray.config.ini
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ driver_args =
[ray.java.path.source]
redis_server = %CONFIG_FILE_DIR%/../build/src/common/thirdparty/redis/src/redis-server
redis_module = %CONFIG_FILE_DIR%/../build/src/common/redis_module/libray_redis_module.so
store = %CONFIG_FILE_DIR%/../build/src/plasma/plasma_store
store = %CONFIG_FILE_DIR%/../build/src/plasma/plasma_store_server
store_manager = %CONFIG_FILE_DIR%/../build/src/plasma/plasma_manager
local_scheduler = %CONFIG_FILE_DIR%/../build/src/local_scheduler/local_scheduler
global_scheduler = %CONFIG_FILE_DIR%/../build/src/global_scheduler/global_scheduler
Expand All @@ -134,7 +134,7 @@ java_jnilib_paths = ray.java.path.jni.package
[ray.java.path.package]
redis_server = %CONFIG_FILE_DIR%/../build/src/common/thirdparty/redis/src/redis-server
redis_module = %CONFIG_FILE_DIR%/../build/src/common/redis_module/libray_redis_module.so
store = %CONFIG_FILE_DIR%/../build/src/plasma/plasma_store
store = %CONFIG_FILE_DIR%/../build/src/plasma/plasma_store_server
store_manager = %CONFIG_FILE_DIR%/../build/src/plasma/plasma_manager
local_scheduler = %CONFIG_FILE_DIR%/../build/src/local_scheduler/local_scheduler
global_scheduler = %CONFIG_FILE_DIR%/../build/src/global_scheduler/global_scheduler
Expand All @@ -147,7 +147,7 @@ java_jnilib_paths = ray.java.path.jni.package
[ray.java.path.deploy]
redis_server = %CONFIG_FILE_DIR%/native/bin/redis-server
redis_module = %CONFIG_FILE_DIR%/native/lib/libray_redis_module.so
store = %CONFIG_FILE_DIR%/native/bin/plasma_store
store = %CONFIG_FILE_DIR%/native/bin/plasma_store_server
store_manager = %CONFIG_FILE_DIR%/native/bin/plasma_manager
local_scheduler = %CONFIG_FILE_DIR%/native/bin/local_scheduler
global_scheduler = %CONFIG_FILE_DIR%/native/bin/global_scheduler
Expand All @@ -156,4 +156,3 @@ python_dir = %CONFIG_FILE_DIR%/python
java_runtime_rewritten_jars_dir = %CONFIG_FILE_DIR%/java/lib/
java_class_paths = ray.java.path.classes.deploy
java_jnilib_paths = ray.java.path.jni.deploy

2 changes: 1 addition & 1 deletion python/ray/plasma/plasma.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def start_plasma_store(plasma_store_memory=DEFAULT_PLASMA_STORE_MEMORY,

plasma_store_executable = os.path.join(
os.path.abspath(os.path.dirname(__file__)),
"../core/src/plasma/plasma_store")
"../core/src/plasma/plasma_store_server")
plasma_store_name = "/tmp/plasma_store{}".format(random_name())
command = [
plasma_store_executable, "-s", plasma_store_name, "-m",
Expand Down
3 changes: 2 additions & 1 deletion python/ray/plasma/test/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ def start_plasma_store(plasma_store_memory=DEFAULT_PLASMA_STORE_MEMORY,
"""
if use_valgrind and use_profiler:
raise Exception("Cannot use valgrind and profiler at the same time.")
plasma_store_executable = os.path.join(pa.__path__[0], "plasma_store")
plasma_store_executable = os.path.join(pa.__path__[0],
"plasma_store_server")
plasma_store_name = "/tmp/plasma_store{}".format(random_name())
command = [
plasma_store_executable, "-s", plasma_store_name, "-m",
Expand Down
3 changes: 2 additions & 1 deletion python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
ray_files = [
"ray/core/src/common/thirdparty/redis/src/redis-server",
"ray/core/src/common/redis_module/libray_redis_module.so",
"ray/core/src/plasma/plasma_store", "ray/core/src/plasma/plasma_manager",
"ray/core/src/plasma/plasma_store_server",
"ray/core/src/plasma/plasma_manager",
"ray/core/src/local_scheduler/local_scheduler",
"ray/core/src/local_scheduler/liblocal_scheduler_library_python.so",
"ray/core/src/global_scheduler/global_scheduler",
Expand Down
4 changes: 2 additions & 2 deletions src/local_scheduler/test/run_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ sleep 1s
./src/common/thirdparty/redis/src/redis-cli set NumRedisShards 1
./src/common/thirdparty/redis/src/redis-cli rpush RedisShards 127.0.0.1:6380

./src/plasma/plasma_store -s /tmp/plasma_store_socket_1 -m 100000000 &
./src/plasma/plasma_store_server -s /tmp/plasma_store_socket_1 -m 100000000 &
sleep 0.5s
./src/local_scheduler/local_scheduler_tests
./src/common/thirdparty/redis/src/redis-cli shutdown
./src/common/thirdparty/redis/src/redis-cli -p 6380 shutdown
killall plasma_store
killall plasma_store_server
4 changes: 2 additions & 2 deletions src/local_scheduler/test/run_valgrind.sh
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ sleep 1s
./src/common/thirdparty/redis/src/redis-cli set NumRedisShards 1
./src/common/thirdparty/redis/src/redis-cli rpush RedisShards 127.0.0.1:6380

./src/plasma/plasma_store -s /tmp/plasma_store_socket_1 -m 100000000 &
./src/plasma/plasma_store_server -s /tmp/plasma_store_socket_1 -m 100000000 &
sleep 0.5s
valgrind --track-origins=yes --leak-check=full --show-leak-kinds=all --leak-check-heuristics=stdstring --error-exitcode=1 ./src/local_scheduler/local_scheduler_tests
./src/common/thirdparty/redis/src/redis-cli shutdown
./src/common/thirdparty/redis/src/redis-cli -p 6380 shutdown
killall plasma_store
killall plasma_store_server
8 changes: 4 additions & 4 deletions src/plasma/test/run_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
# Cause the script to exit if a single command fails.
set -e

./src/plasma/plasma_store -s /tmp/plasma_store_socket_1 -m 0 &
./src/plasma/plasma_store_server -s /tmp/plasma_store_socket_1 -m 0 &
sleep 1
./src/plasma/manager_tests
killall plasma_store
killall plasma_store_server

LaunchRedis() {
port=$1
Expand Down Expand Up @@ -37,11 +37,11 @@ sleep 1s
./src/common/thirdparty/redis/src/redis-cli set NumRedisShards 1
./src/common/thirdparty/redis/src/redis-cli rpush RedisShards 127.0.0.1:6380
sleep 1
./src/plasma/plasma_store -s /tmp/store1 -m 1000000000 &
./src/plasma/plasma_store_server -s /tmp/store1 -m 1000000000 &
plasma1_pid=$!
./src/plasma/plasma_manager -m /tmp/manager1 -s /tmp/store1 -h 127.0.0.1 -p 11111 -r 127.0.0.1:6379 &
plasma2_pid=$!
./src/plasma/plasma_store -s /tmp/store2 -m 1000000000 &
./src/plasma/plasma_store_server -s /tmp/store2 -m 1000000000 &
plasma3_pid=$!
./src/plasma/plasma_manager -m /tmp/manager2 -s /tmp/store2 -h 127.0.0.1 -p 22222 -r 127.0.0.1:6379 &
plasma4_pid=$!
Expand Down
4 changes: 2 additions & 2 deletions src/plasma/test/run_valgrind.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ set -x
# Cause the script to exit if a single command fails.
set -e

./src/plasma/plasma_store -s /tmp/plasma_store_socket_1 -m 0 &
./src/plasma/plasma_store_server -s /tmp/plasma_store_socket_1 -m 0 &
sleep 1
valgrind --track-origins=yes --leak-check=full --show-leak-kinds=all --leak-check-heuristics=stdstring --error-exitcode=1 ./src/plasma/manager_tests
killall plasma_store
killall plasma_store_server
2 changes: 1 addition & 1 deletion src/ray/raylet/object_manager_integration_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class TestObjectManagerBase : public ::testing::Test {
this->server1.reset();
this->server2.reset();

int s = system("killall plasma_store &");
int s = system("killall plasma_store_server &");
ASSERT_TRUE(!s);

std::string cmd_str = test_executable.substr(0, test_executable.find_last_of("/"));
Expand Down
2 changes: 1 addition & 1 deletion src/ray/test/run_object_manager_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ else
LOAD_MODULE_ARGS="--loadmodule ${REDIS_MODULE}"
fi

STORE_EXEC="$CORE_DIR/src/plasma/plasma_store"
STORE_EXEC="$CORE_DIR/src/plasma/plasma_store_server"

# Allow cleanup commands to fail.
$REDIS_DIR/redis-cli -p 6379 shutdown || true
Expand Down
2 changes: 1 addition & 1 deletion src/ray/test/run_object_manager_valgrind.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ fi
CORE_DIR="$RAY_ROOT/build"
REDIS_DIR="$CORE_DIR/src/common/thirdparty/redis/src"
REDIS_MODULE="$CORE_DIR/src/common/redis_module/libray_redis_module.so"
STORE_EXEC="$CORE_DIR/src/plasma/plasma_store"
STORE_EXEC="$CORE_DIR/src/plasma/plasma_store_server"
VALGRIND_CMD="valgrind --track-origins=yes --leak-check=full --show-leak-kinds=all --leak-check-heuristics=stdstring --error-exitcode=1"

if [[ "${RAY_USE_NEW_GCS}" = "on" ]]; then
Expand Down
2 changes: 1 addition & 1 deletion src/ray/test/start_raylet.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ if [[ `stat $STORE_SOCKET_NAME` ]]; then
rm $STORE_SOCKET_NAME
fi

./src/plasma/plasma_store -m 1000000000 -s $STORE_SOCKET_NAME &
./src/plasma/plasma_store_server -m 1000000000 -s $STORE_SOCKET_NAME &
./src/ray/raylet/raylet $RAYLET_SOCKET_NAME $STORE_SOCKET_NAME 127.0.0.1 127.0.0.1 6379 &

echo
Expand Down
2 changes: 1 addition & 1 deletion src/ray/test/start_raylets.sh
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ for i in `seq 1 $NUM_RAYLETS`; do
rm $STORE_SOCKET_NAME
fi

./src/plasma/plasma_store -m 1000000000 -s $STORE_SOCKET_NAME &
./src/plasma/plasma_store_server -m 1000000000 -s $STORE_SOCKET_NAME &
./src/ray/raylet/raylet $RAYLET_SOCKET_NAME $STORE_SOCKET_NAME 127.0.0.1 127.0.0.1 6379 &

echo
Expand Down
4 changes: 2 additions & 2 deletions thirdparty/scripts/build_arrow.sh
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ else
exit 1
fi

# The PR for this commit is https://github.com/apache/arrow/pull/2368. We
# The PR for this commit is https://github.com/apache/arrow/pull/2458. We
# include the link here to make it easier to find the right commit because
# Arrow often rewrites git history and invalidates certain commits.
TARGET_COMMIT_ID=4660833b2c5ef63a97445e304b8f72a2e0170f9c
TARGET_COMMIT_ID=fda4b3dcfc773612b12973df5053193f236fc696
build_arrow() {
echo "building arrow"
# Make sure arrow will be built again when building ray for java later than python
Expand Down