Allow grpcio >= 1.48 #26765
Merged
Allow grpcio >= 1.48 #26765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishbone
approved these changes
Jul 20, 2022
rkooo567
approved these changes
Jul 20, 2022
|
Btw, @scv119 is this version restriction still correct (grpc < 1.43) given we fixed the root cause in the master? (upgrading the internal grpc version)? |
|
cc @richardliaw can you approve the requirements.txt change? we need code owner approval |
richardliaw
approved these changes
Jul 21, 2022
Rohan138
pushed a commit
to Rohan138/ray
that referenced
this pull request
Jul 28, 2022
The previously observed Python grpc warning / logspam seems to have been fixed for grpcio >= 1.48. And users would like to upgrade beyond grpcio 1.43 for better M1 support. However, grpcio 1.48 has not been released yet, so there is still a risk this change needs to be reverted if any problem is discovered later with Ray nightly + grpcio 1.48. Signed-off-by: Rohan138 <rapotdar@purdue.edu>
scv119
added a commit
that referenced
this pull request
Jul 29, 2022
scv119
added a commit
that referenced
this pull request
Jul 29, 2022
1 task
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
The previously observed Python grpc warning / logspam seems to have been fixed for grpcio >= 1.48. And users would like to upgrade beyond grpcio 1.43 for better M1 support. However, grpcio 1.48 has not been released yet, so there is still a risk this change needs to be reverted if any problem is discovered later with Ray nightly + grpcio 1.48. Signed-off-by: Stefan van der Kleij <s.vanderkleij@viroteq.com>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
This reverts commit 6acd0a4. Signed-off-by: Stefan van der Kleij <s.vanderkleij@viroteq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The previously observed Python grpc warning / logspam seems to have been fixed for
grpcio>= 1.48. And users would like to upgrade beyondgrpcio1.43 for better M1 support. However,grpcio1.48 has not been released yet, so there is still a risk this change needs to be reverted if any problem is discovered later with Ray nightly + grpcio 1.48.Related issue number
Closes #22518
Checks
scripts/format.shto lint the changes in this PR.