-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[air] Add xgboost release test for silver tier(10-node case). #26460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
nice! How do we get this onto the dashboard? |
@Yard1 Do you know why the result shows
There is a |
waiting for Kai to set something up in his PR and will just follow the practice. |
Actually to be 100% sure can we run the training part and prediction part as separate subprocesses? |
also @xwjiang2010 we are missing the EBS config, I think that may be a cause for slowdown |
@xwjiang2010 we probably can bring down the disk size to like 200 GBs to save a little money! |
@Yard1 haha sounds good :) |
I think you can use this? https://docs.ray.io/en/latest/ray-core/objects/object-spilling.html#stats |
|
pretty big deviation here
run2:
The data loading part is the cause of slowdown in 2nd run. @Yard1 , if you are OK, I am going to relax the criteria a bit more, say 1000s. |
Relax the threshold.
That should be fine, thanks |
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
…oject#26460) Co-authored-by: Antoni Baum <antoni.baum@protonmail.com> Co-authored-by: Richard Liaw <rliaw@berkeley.edu> Signed-off-by: Xiaowei Jiang <xwjiang2010@gmail.com>
…oject#26460) Co-authored-by: Antoni Baum <antoni.baum@protonmail.com> Co-authored-by: Richard Liaw <rliaw@berkeley.edu> Signed-off-by: Stefan van der Kleij <s.vanderkleij@viroteq.com>
Why are these changes needed?
Add release test for air xgboost benchmark.
Will take a look at the number first running in release test environment and add a proper triggering threshold (time * 1.1).
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.