Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ray/widgets/templates/ files to wheel (fix #26452) #26457

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

pcmoritz
Copy link
Contributor

@pcmoritz pcmoritz commented Jul 12, 2022

Why are these changes needed?

Add the html template files in ray/widgets/templates/ to the wheel to make sure the Jupyter widget that is displayed in ray.init() works for the Ray wheels.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@pcmoritz pcmoritz merged commit b155bc4 into ray-project:master Jul 12, 2022
@pcmoritz pcmoritz deleted the fix-26452 branch July 12, 2022 18:24
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
…y-project#26457)

Add the html template files in `ray/widgets/templates/` to the wheel to make sure the Jupyter widget that is displayed in `ray.init()` works for the Ray wheels.

Signed-off-by: Stefan van der Kleij <s.vanderkleij@viroteq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants