-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[Core] Add retry exception allowlist for user-defined filteri… #26289
Merged
stephanie-wang
merged 2 commits into
ray-project:master
from
antgroup:dev_revert_for_test
Jul 5, 2022
Merged
Revert "[Core] Add retry exception allowlist for user-defined filteri… #26289
stephanie-wang
merged 2 commits into
ray-project:master
from
antgroup:dev_revert_for_test
Jul 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng of retryable application-level errors. (ray-project#25896)" This reverts commit 2a4d22f.
scv119
approved these changes
Jul 5, 2022
clarkzinzow
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep we should revert and then open a PR unreverting that fixes the Windows test. I'll take a look at doing the latter tomorrow.
@edoakes @ericl @maxpumperla @pcmoritz @richardliaw @simon-mo need other code owner approval, who can click? |
stephanie-wang
approved these changes
Jul 5, 2022
jjyao
approved these changes
Jul 5, 2022
fishbone
approved these changes
Jul 5, 2022
wuisawesome
approved these changes
Jul 5, 2022
ericl
approved these changes
Jul 5, 2022
truelegion47
pushed a commit
to truelegion47/ray
that referenced
this pull request
Jul 6, 2022
* master: (104 commits) [Serve] Java Client API and End to End Tests (ray-project#22726) [Docs] Small fix to AIR examples descriptions (ray-project#26227) [Deployment Graph] Move `Deployment` creation outside to build function (ray-project#26129) [K8s][Ray Operator] Ignore resource requests when detected container resources. (ray-project#26234) Revert "[Core] Add retry exception allowlist for user-defined filteri… (ray-project#26289) [ci] pin gpustat (ray-project#26311) [tune] fix `set_tune_experiment` (ray-project#26298) Revert "Revert "[AIR][Serve] Rename ModelWrapperDeployment -> PredictorDeployment"" (ray-project#26231) [Release] Use nightly base images for release tests (ray-project#25373) Revert "[Core] fix gRPC handlers' unlimited active calls configuration (ray-project#25626)" (ray-project#26202) [RLlib] Some Docs fixes (2). (ray-project#26265) [C++ worker] Refine worker context and more (ray-project#26281) Fix file_system_monitor.cc message (ray-project#26143) [Java] Make Java test more stable (ray-project#26282) [air] Do not warn of `checkpoint_dir` if it's coming from us (base_trainer). (ray-project#26259) [Datasets] Support drop_columns API (ray-project#26200) [Datasets] Fix max number of actors for default actor pool strategy (ray-project#26266) [ci] Stop syncer staging tests (ray-project#26273) [core][gcs] Add storage namespace to redis storage in GCS. (ray-project#25994) [workflow] Deprecate workflow.create (ray-project#26106) ...
clarkzinzow
added a commit
to clarkzinzow/ray
that referenced
this pull request
Aug 4, 2022
… filteri… (ray-project#26289)" This reverts commit cf7305a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The related issue #26287