Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] More Trainer -> Algorithm renaming cleanups. #25869

Merged

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jun 16, 2022

More Trainer -> Algorithm renaming cleanups.

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@@ -75,7 +75,7 @@ def get_cli_args():
return args


# The modified Trainer class we will use. This is the exact same
# The modified Algorithm class we will use. This is the exact same
# as a PPO, but with the additional default_resource_request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... same as for PPO ... ?
... same as PPO ... ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will change

Copy link
Contributor

@ArturNiederfahrenhorst ArturNiederfahrenhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sven1977 sven1977 merged commit 9669305 into ray-project:master Jun 20, 2022
@sven1977 sven1977 deleted the move_tests_from_agents_to_algorithms branch June 2, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants