[xray] Fix typo concerning heartbeat_timeout_milliseconds in monitor #2586
Conversation
src/ray/raylet/monitor.cc
Outdated
| @@ -16,7 +16,7 @@ namespace raylet { | |||
| Monitor::Monitor(boost::asio::io_service &io_service, const std::string &redis_address, | |||
| int redis_port) | |||
| : gcs_client_(), | |||
| heartbeat_timeout_ms_(RayConfig::instance().num_heartbeats_timeout()), | |||
| heartbeat_timeout_ms_(RayConfig::instance().heartbeat_timeout_milliseconds()), | |||
There was a problem hiding this comment.
Looking at the way the field is used, I actually think num_heartbeats_timeout is correct and that the field is misnamed.
There was a problem hiding this comment.
You are right, I fixed it!
|
Test PASSed. |
|
Test PASSed. |
|
Test FAILed. |
|
jenkins retest this please |
|
Test PASSed. |
This is not affecting default behavior since the two constants are the same, but we should use the correct one (e.g. if the user changes ray_constants.h).