Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][core] Add option for parallel ci for ray core tests #25801

Merged
merged 11 commits into from
Jun 16, 2022

Conversation

fishbone
Copy link
Contributor

@fishbone fishbone commented Jun 15, 2022

Why are these changes needed?

This is the first step to enable the parallel tests for ray core ci. To reduce the noise this test only add the option and not enable them. Parallel CI can be 40%-60% faster compared with running them one-by-one.

We'll enable them by bk jobs one-by-one.

Prototype here #25612

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@fishbone
Copy link
Contributor Author

LINT is failing, and I'm working to fix that. Right now, lint will sort imports which causes a lot of issues for the reviewer. @clarng is working on the fixing.

@clarng
Copy link
Contributor

clarng commented Jun 15, 2022

LINT is failing, and I'm working to fix that. Right now, lint will sort imports which causes a lot of issues for the reviewer. @clarng is working on the fixing.

This will help minimize the change: #25824

Copy link
Member

@mwtian mwtian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great if we can have parallel testing!

I wonder if there is a way to not repeat the pytest invocation logic in the all test files, e.g. would it be possible to setup these in Bazel? Anyway the change looks like a good improvement!

@mwtian mwtian mentioned this pull request Jun 15, 2022
6 tasks
@fishbone
Copy link
Contributor Author

@mwtian that's good point. I feel we probably need to change the Bazel rule for this. Once we get that, I think we can also run multiple tests in parallel in a container.

@fishbone fishbone merged commit 4c5c576 into ray-project:master Jun 16, 2022
@fishbone fishbone deleted the parallel-ci branch June 16, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants