-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci][core] Add option for parallel ci for ray core tests #25801
Conversation
LINT is failing, and I'm working to fix that. Right now, lint will sort imports which causes a lot of issues for the reviewer. @clarng is working on the fixing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great if we can have parallel testing!
I wonder if there is a way to not repeat the pytest invocation logic in the all test files, e.g. would it be possible to setup these in Bazel? Anyway the change looks like a good improvement!
@mwtian that's good point. I feel we probably need to change the Bazel rule for this. Once we get that, I think we can also run multiple tests in parallel in a container. |
Why are these changes needed?
This is the first step to enable the parallel tests for ray core ci. To reduce the noise this test only add the option and not enable them. Parallel CI can be 40%-60% faster compared with running them one-by-one.
We'll enable them by bk jobs one-by-one.
Prototype here #25612
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.