[air] remove fully_executed from Tune. #25750
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Remove fully_executed from Tune layer.
I tried using my test bench by adding the following in ProgressReporter (printed every 5 seconds).
And run Tune job with 10 trials (they should all share the same Dataset object).
The console output is a few lines of
And then the output changes to
I cannot quite explain why the usage is doubled, but at least it's not going linear with the size of trials (which is 10). I take it as a proof...
For check-ingest, I intentionally removed the session around preprocessing, for two reasons:
I still have 2 copies of post-processed dataset, which seems very inefficient.
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.