Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flakey] Skip ray_syncer_test for ubsan. #25477

Merged
merged 1 commit into from
Jun 5, 2022

Conversation

fishbone
Copy link
Contributor

@fishbone fishbone commented Jun 4, 2022

Why are these changes needed?

From the message:

[       OK ] SyncerTest.TestMToN (13132 ms)
[----------] 5 tests from SyncerTest (43175 ms total)

[----------] Global test environment tear-down
[==========] 8 tests from 2 test suites ran. (43176 ms total)
[  PASSED  ] 8 tests.
external/com_github_grpc_grpc/src/core/lib/iomgr/ev_posix.cc:314:19: runtime error: member access within null pointer of type 'const struct grpc_event_engine_vtable'

This can only be reproduced by running with Bazel test so far. With gdb, it won't be reproduced. It seems like some issue with the grpc maybe the reactor API.
Given that the ASAN test, which is supposed to catch the issue, runs well, and a considerable time has been spent investigating this one but no progress, skip this test for now.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@fishbone fishbone linked an issue Jun 4, 2022 that may be closed by this pull request
@fishbone fishbone merged commit acf210f into ray-project:master Jun 5, 2022
@fishbone fishbone deleted the skip-syncer-ubsan branch June 5, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core][flakey-test] linux://:ray_syncer_test
3 participants