Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Python3.7 wheels support #2546

Merged
merged 7 commits into from
Oct 19, 2018
Merged

Adding Python3.7 wheels support #2546

merged 7 commits into from
Oct 19, 2018

Conversation

devin-petersohn
Copy link
Member

What do these changes do?

Build Python 3.7 wheels during travis tests.

Related issue number

#1115

@robertnishihara
Copy link
Collaborator

Nice!

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/7145/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/7144/
Test PASSed.

robertnishihara
robertnishihara reviewed Aug 2, 2018
View reviewed changes
python/build-wheel-manylinux1.sh
@@ -13,7 +13,7 @@ rm -f /usr/bin/python2
ln -s /opt/python/cp27-cp27m/bin/python2 /usr/bin/python2

mkdir .whl
for PYTHON in cp27-cp27mu cp34-cp34m cp35-cp35m cp36-cp36m; do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether this works or not just depends on whether the base image already has Python 3.7 on it. The base image is the one used for building Arrow wheels.

@pcmoritz
Copy link
Contributor

we should revisit this, arrow now has support for 3.7 I think; see also #1115

@pcmoritz pcmoritz mentioned this pull request Oct 17, 2018
Closed
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8708/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8710/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8715/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8736/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8738/
Test PASSed.

pcmoritz
pcmoritz approved these changes Oct 19, 2018
View reviewed changes
Copy link
Contributor

@pcmoritz pcmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I made sure this works with the earliest numpy compatible with python 3.7 on mac, see changes in the PR.

@pcmoritz pcmoritz merged commit 8fcdafc into ray-project:master Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertnishihara robertnishihara robertnishihara left review comments

@pcmoritz pcmoritz pcmoritz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devin-petersohn @robertnishihara @AmplabJenkins @pcmoritz