Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[air] add to_air_checkpoint method for inference only workload. #25444

Merged
merged 14 commits into from
Jun 7, 2022

Conversation

xwjiang2010
Copy link
Contributor

@xwjiang2010 xwjiang2010 commented Jun 3, 2022

Why are these changes needed?

Follow up on our last discussion for supporting piecemeal fashion air users.
Only did for tensorflow for now, want to collect some feedback on API naming, package structure etc and I will add others.

Related issue number

#25224

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to package ref and mention it in key concepts?


Args:
model: A pretrained model.
preprocessor: Stateless preprocessor only. The preprocessing logic will
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this have to be a stateless preprocessor only? This can be a stateful preprocessor that's already been fit right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrased..

@xwjiang2010
Copy link
Contributor Author

Add to package ref and mention it in key concepts?

Added a session in key concepts

doc/source/_toc.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, did not review new models very carefully -- ping when tests pass

@amogkam amogkam merged commit 76b34d4 into ray-project:master Jun 7, 2022
sumanthratna pushed a commit to sumanthratna/ray that referenced this pull request Jun 8, 2022
…project#25444)

Follow up on our last discussion for supporting piecemeal fashion air users.
Only did for tensorflow for now, want to collect some feedback on API naming, package structure etc and I will add others.
@xwjiang2010 xwjiang2010 deleted the predictor branch July 26, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants