Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rllib] Document auto-concat in a3c #2533

Merged
merged 2 commits into from
Aug 1, 2018
Merged

Conversation

ericl
Copy link
Contributor

@ericl ericl commented Aug 1, 2018

No description provided.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/7086/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/7094/
Test FAILed.

@ericl ericl changed the title [rllib] Remove auto-concat in a3c [rllib] Document auto-concat in a3c Aug 1, 2018
@ericl
Copy link
Contributor Author

ericl commented Aug 1, 2018

So based on tests, this actually degrades async mode more than expected, because what this auto-concat is doing is reducing the amount of off-policy data.

I'm pretty sure we can get sync sampling to work as fast as async with some batch size tuning, but for now, just document it so we don't need to worry about perf regressions.

@ericl ericl merged commit d9a36c4 into ray-project:master Aug 1, 2018
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/7116/
Test FAILed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants