Support file:// for runtime_env working directories in jobs #25062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericl
reviewed
May 22, 2022
ericl
approved these changes
May 22, 2022
edoakes
reviewed
May 23, 2022
There was a problem hiding this comment.
- Is it possible to add a local integration test for this?
- Could you add this to the docs at https://docs.ray.io/en/latest/ray-core/handling-dependencies.html#remote-uris ?
|
Also, does this require a separate installation similar to |
edoakes
reviewed
May 23, 2022
| @@ -50,12 +50,13 @@ def __new__(cls, value, doc=None): | |||
| HTTPS = "https", "Remote https path, assumes everything packed in one zip file." | |||
| S3 = "s3", "Remote s3 path, assumes everything packed in one zip file." | |||
| GS = "gs", "Remote google storage path, assumes everything packed in one zip file." | |||
| NFS = "file", "NFS storage path, assumes everything packed in one zip file." | |||
There was a problem hiding this comment.
Prefer to just call it file:// to match smart_open and because it can be used more generally. We can suggest in docs that people use this for NFS.
Co-authored-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
pcmoritz
changed the title
|
Yes, it requires |
ericl
reviewed
May 24, 2022
ericl
reviewed
May 24, 2022
| @@ -537,6 +537,13 @@ Currently, three types of remote URIs are supported for hosting ``working_dir`` | |||
|
|
|||
| - ``runtime_env = {"working_dir": "gs://example_bucket/example_file.zip"}`` | |||
|
|
|||
| - ``FILE``: ``FILE`` refers to URIs starting with ``file://`` that point to compressed packages stored on a local file system or a network file system. | |||
| To use packages via ``FILE`` URIs, you must have the ``smart_open`` library (you can install it using ``pip install smart_open``). | |||
There was a problem hiding this comment.
Hm, I think we could probably use normal open for this case, just need to find the one line runtime env to special case.
There was a problem hiding this comment.
Good idea, I fixed it!
Co-authored-by: Eric Liang <ekhliang@gmail.com>
edoakes
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This makes it possible to use an NFS file system that is shared on a cluster for runtime_env working directories.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.