-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depend on uvicorn[standard] instead of uvicorn so that it pulls in uvloop #25027
Conversation
Would you mind changing https://github.com/ray-project/ray/blob/master/python/setup.py#L219 as well? |
done |
One last location containing |
Doc should be fine left unchanged though.
On May 20, 2022, GitHub ***@***.***> wrote:
One last location containing uvicorn is doc/requirements-doc.txt
—
Reply to this email directly, view it on GitHub <https://github.com/ray-
project/ray/pull/25027#issuecomment-1133157697>, or unsubscribe
<https://github.com/notifications/unsubscribe-
auth/AFBD7A6O2O5TMSBBTJIPZKDVK7E6RANCNFSM5WPVBDAA>.
You are receiving this because you were assigned.Message ID: <ray-
***@***.***>
|
Thanks for the contribution @fkaleo ! What still remains to be done for this PR? |
Looks like I can't push to this branch.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM given the dep change is scoped to [serve]
…t it pulls in uvloop (ray-project#25027)" (ray-project#25530) This reverts commit 9a510f9.
Why are these changes needed?
Ensures that
uvloop
is installed thus making uvicorn many times faster.Related issue number
Closes #25023
Checks
scripts/format.sh
to lint the changes in this PR.