Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on uvicorn[standard] instead of uvicorn so that it pulls in uvloop #25027

Merged
merged 6 commits into from
Jun 6, 2022

Conversation

fkaleo
Copy link
Contributor

@fkaleo fkaleo commented May 20, 2022

Why are these changes needed?

Ensures that uvloop is installed thus making uvicorn many times faster.

Related issue number

Closes #25023

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@fkaleo fkaleo changed the title Depend on uvicorn[standard] instead of uvicorn so that it pulls in uv… Depend on uvicorn[standard] instead of uvicorn so that it pulls in uvloop May 20, 2022
@mwtian mwtian assigned mwtian and unassigned mwtian May 20, 2022
@simon-mo simon-mo self-assigned this May 20, 2022
@simon-mo
Copy link
Contributor

Would you mind changing https://github.com/ray-project/ray/blob/master/python/setup.py#L219 as well?

@fkaleo
Copy link
Contributor Author

fkaleo commented May 20, 2022

Would you mind changing https://github.com/ray-project/ray/blob/master/python/setup.py#L219 as well?

done

@fkaleo fkaleo marked this pull request as ready for review May 20, 2022 17:35
@mwtian
Copy link
Member

mwtian commented May 20, 2022

One last location containing uvicorn is doc/requirements-doc.txt

@simon-mo
Copy link
Contributor

simon-mo commented May 20, 2022 via email

@zhe-thoughts
Copy link
Collaborator

Thanks for the contribution @fkaleo !

What still remains to be done for this PR?

@simon-mo
Copy link
Contributor

simon-mo commented Jun 1, 2022

Looks like I can't push to this branch.

  • @fkaleo would you mind merge upstream master to refresh the tests?
  • @ericl @richardliaw can code owners please approve the dependency changes for Serve in setup.py?

Copy link
Contributor

@ericl ericl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given the dep change is scoped to [serve]

@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jun 6, 2022
@simon-mo simon-mo merged commit 9a510f9 into ray-project:master Jun 6, 2022
fishbone added a commit that referenced this pull request Jun 6, 2022
fishbone added a commit that referenced this pull request Jun 6, 2022
sumanthratna pushed a commit to sumanthratna/ray that referenced this pull request Jun 8, 2022
sumanthratna pushed a commit to sumanthratna/ray that referenced this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ray docker images do not have uvloop installed
6 participants