Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the check of java primitive types #2495

Merged
merged 1 commit into from
Jul 27, 2018

Conversation

raulchen
Copy link
Contributor

This check isn't needed. Because the compiler will automatically box primitive types.

Not in this PR:
API document needs to be updated as well, which will be done in a new PR together with other changes.

cc @salah-man

Copy link
Contributor

@eric-jj eric-jj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6901/
Test PASSed.

@salah-man
Copy link
Contributor

It's great, and maybe better add more test case to mvn test (CI will automatic add) especially have primitive types for input and out put of common remote function and Actor function.

@robertnishihara robertnishihara merged commit 5b015f9 into ray-project:master Jul 27, 2018
@raulchen raulchen deleted the primitive_check branch July 29, 2018 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants