Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Core] Revert "[Core] Batch PinObjectIDs requests from Rayl… #24865

Closed
wants to merge 2 commits into from

Conversation

mwtian
Copy link
Member

@mwtian mwtian commented May 16, 2022

…et client (#24322)" and "[Core] rename PinObjectIDs to PinObjectID (#24451)" (#24741)"

This reverts commit 02042e1.

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

…et client (ray-project#24322)" and "[Core] rename `PinObjectIDs` to `PinObjectID` (ray-project#24451)" (ray-project#24741)"

This reverts commit 02042e1.
@rkooo567
Copy link
Contributor

Are we going to do this?

@rkooo567 rkooo567 self-assigned this May 27, 2022
@mwtian
Copy link
Member Author

mwtian commented May 27, 2022

Need a bit of time to test a version that batches without affecting perf.

@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jun 9, 2022
@mwtian mwtian removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jun 9, 2022
@stale
Copy link

stale bot commented Jul 10, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Jul 10, 2022
@mwtian mwtian closed this Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale The issue is stale. It will be closed within 7 days unless there are further conversation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants