Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] MADDPG: Move into main algorithms folder and add proper unit and learning tests. #24579

Merged
merged 18 commits into from
May 24, 2022
Merged

[RLlib] MADDPG: Move into main algorithms folder and add proper unit and learning tests. #24579

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6483bde
wip.
sven1977 May 5, 2022
e1000ff
wip.
sven1977 May 6, 2022
da80644
Merge branch 'master' of https://github.com/ray-project/ray into madd…
sven1977 May 6, 2022
3183f7e
Merge branch 'master' of https://github.com/ray-project/ray into madd…
sven1977 May 6, 2022
f5f2693
wip.
sven1977 May 7, 2022
ea77996
Merge branch 'master' of https://github.com/ray-project/ray into madd…
sven1977 May 10, 2022
e489bbc
Merge branch 'master' of https://github.com/ray-project/ray into madd…
sven1977 May 17, 2022
0224cf3
wip
sven1977 May 17, 2022
1eab03a
Merge branch 'master' of https://github.com/ray-project/ray into madd…
sven1977 May 17, 2022
f06f28e
wip
sven1977 May 17, 2022
f9b7480
Merge branch 'master' of https://github.com/ray-project/ray into madd…
sven1977 May 18, 2022
6446e51
wip
sven1977 May 18, 2022
ca4d93e
wip
sven1977 May 18, 2022
6c86ce7
wip.
sven1977 May 22, 2022
42de26f
Merge branch 'master' of https://github.com/ray-project/ray into madd…
sven1977 May 22, 2022
0b21d2d
wip.
sven1977 May 22, 2022
af64d24
Merge branch 'master' of https://github.com/ray-project/ray into madd…
sven1977 May 24, 2022
4fbf42e
wip.
sven1977 May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
wip
  • Loading branch information
@sven1977
sven1977 committed May 18, 2022
commit ca4d93ef47bfb33cb77dcf8c7720898276d585e2
10 changes: 9 additions & 1 deletion rllib/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ py_test(
py_test(
name = "learning_tests_two_step_game_maddpg",
main = "tests/run_regression_tests.py",
tags = ["team:ml", "tf_only", "learning_tests", "learning_tests_discrete"],
tags = ["team:ml", "tf_only", "no_tf_eager_tracing", "learning_tests", "learning_tests_discrete"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we maybe instead add this to the weekly ci -- I feel like we don't need to as widely support this algorithm until there is a customer use case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question: I think we should move toward:

  • CI-tests: small tasks that can be learnt in 1-2 min (CartPole, TwoStepGame, maybe Pendulum or simpler cont. actions problem)
  • nightly tests: hard tasks, requiring GPU + ~1h of completion on >1 workers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this test here for now to roughly match the other algos' coverage (everyone has CartPole/Pendulum tests in the CI, which is ok).

size = "large",
srcs = ["tests/run_regression_tests.py"],
data = ["tuned_examples/maddpg/two-step-game-maddpg.yaml"],
Expand Down Expand Up @@ -786,6 +786,14 @@ py_test(
srcs = ["algorithms/marwil/tests/test_bc.py"]
)

# MADDPGTrainer
py_test(
name = "test_maddpg",
tags = ["team:ml", "trainers_dir"],
size = "medium",
srcs = ["agents/maddpg/tests/test_maddpg.py"]
)

# MAMLTrainer
py_test(
name = "test_maml",
Expand Down