Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci/release] Fix module import errors in release tests #24334

Merged
merged 1 commit into from
Apr 29, 2022
Merged

[ci/release] Fix module import errors in release tests #24334

merged 1 commit into from
Apr 29, 2022

Conversation

krfricke
Copy link
Contributor

@krfricke krfricke commented Apr 29, 2022 •
edited by xwjiang2010
Loading

Why are these changes needed?

After #24066, some release tests are running into:

ModuleNotFoundError: No module named 'ray.train.impl'

This PR simply adds a __init__.py file to resolve this.

We also add a 5 wecond delay for client runners in release test to give clusters a bit of slack to come up (and avoid ray client connection errors)

Related issue number

Closes #24325

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@krfricke krfricke requested review from Yard1 and amogkam April 29, 2022 13:25
avnishn
avnishn approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@avnishn avnishn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you describe which release tests this fixes

@krfricke
Copy link
Contributor Author

@xwjiang2010 xwjiang2010 mentioned this pull request Apr 29, 2022
Closed
@krfricke krfricke merged commit dd87e61 into ray-project:master Apr 29, 2022
@krfricke krfricke deleted the ci/release/fix-impl branch April 29, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yard1 Yard1 Yard1 approved these changes

@avnishn avnishn avnishn approved these changes

@xwjiang2010 xwjiang2010 xwjiang2010 approved these changes

@amogkam amogkam Awaiting requested review from amogkam

Assignees

@amogkam amogkam

@Yard1 Yard1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[release] golden_notebook_tune_serve_test is consistently failing
5 participants
@krfricke @Yard1 @avnishn @xwjiang2010 @amogkam