-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade arrow to include the plasma TensorFlow op #2412
Conversation
Test FAILed. |
@pcmoritz Does this build the TF op? How does the user use the op? |
I activated compiling the op now, an example usage is here: https://github.com/apache/arrow/blob/master/python/pyarrow/tests/test_plasma_tf_op.py It should be tested out/maybe a test added before this is merged. |
Test FAILed. |
Test FAILed. |
Test PASSed. |
Test FAILed. |
jenkins retest this please |
Test FAILed. |
jenkins retest this please |
@@ -2,6 +2,8 @@ set(GFLAGS_VERSION "2.2.0") | |||
set(GTEST_VERSION "1.8.0") | |||
set(GBENCHMARK_VERSION "1.1.0") | |||
|
|||
set(EP_CXX_FLAGS "${EP_CXX_FLAGS} -D_GLIBCXX_USE_CXX11_ABI=0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
document
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Please address the minor comments and then we can merge it.
Test PASSed. |
Test FAILed. |
The main change in arrow relevant here is apache/arrow#2104
Can be built in the following way:
and then used as shown in https://github.com/pschafhalter/arrow/blob/50c66352ea87aa985ac0d70f6ea97c1f7423bd92/python/pyarrow/tests/test_plasma_tf_op.py