Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[air] Use checkpoint.as_directory() instead of cleaning up manually #24113

Merged
merged 2 commits into from
Apr 23, 2022
Merged

[air] Use checkpoint.as_directory() instead of cleaning up manually #24113

merged 2 commits into from
Apr 23, 2022

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

Follow-up from #23908

Instead of manually deleting checkpoint paths after calling to_directory(), we should utilize Checkpoint.as_directory() when possible.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@krfricke krfricke requested review from Yard1, amogkam and ericl April 22, 2022 17:27
amogkam
amogkam approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@krfricke krfricke merged commit 0360100 into ray-project:master Apr 23, 2022
@krfricke krfricke deleted the air/with-checkpoint-dir branch April 23, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amogkam amogkam amogkam approved these changes

@Yard1 Yard1 Yard1 approved these changes

@ericl ericl Awaiting requested review from ericl

Assignees

@ericl ericl

@amogkam amogkam

@Yard1 Yard1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krfricke @amogkam @Yard1 @ericl