[3][cleanup][gcs] Remove redis based pubsub. #23520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3-cpp-pubsub-remove
fishbone
changed the title
…3-cpp-pubsub-remove
…3-cpp-pubsub-remove
ericl
approved these changes
Mar 28, 2022
ericl
added
the
@author-action-required
6 tasks
fishbone
changed the title
|
@mwtian could you help review this PR as well? |
|
Will take a look tomorrow. |
6 tasks
mwtian
approved these changes
Mar 30, 2022
src/mock/ray/pubsub/publisher.h
Outdated
| @@ -84,30 +78,40 @@ class MockPublisherInterface : public PublisherInterface { | |||
| namespace ray { | |||
| namespace pubsub { | |||
|
|
|||
| instrumented_io_context __io_service; | |||
There was a problem hiding this comment.
Double underscore prefixes are reserved for compilers. Ideally, we don't definite variables in headers, unless with inline or as a static local variable: https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables.
Also IIUC files under src/mock are generated programmatically at the beginning. Should we keep it that way and put customized mocks in other locations? Then we would be able to re-run the tool to generate new mocks if needed. Otherwise it seems easy for mocks and actual interfaces to diverge.
mwtian
approved these changes
Mar 30, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR removes redis based pubsub.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.