Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linkcheck flakiness #23482

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Conversation

pcmoritz
Copy link
Contributor

Why are these changes needed?

As seen in https://buildkite.com/ray-project/ray-builders-branch/builds/6736#de2e23c9-3ec1-4c1b-83cb-41ae658ef1f8

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that we keep adding to this list :-D

@krfricke krfricke merged commit 46c1b98 into ray-project:master Mar 25, 2022
@pcmoritz
Copy link
Contributor Author

Haha the hypothesis is that there are a few websites that cause most of the flakiness and we just need to deactivate the checking for them -- if that turns out not to be true, I'll deactivate all external link checking except for github :)

@pcmoritz pcmoritz deleted the fix-linkcheck-2 branch March 25, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants