-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[RLlib] Impala training iteration fn #23454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sven1977
merged 71 commits into
ray-project:master
from
avnishn:impala_training_iteration_fn
May 5, 2022
Merged
[RLlib] Impala training iteration fn #23454
sven1977
merged 71 commits into
ray-project:master
from
avnishn:impala_training_iteration_fn
May 5, 2022
+412
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…la_training_iteration_fn # Conflicts: # rllib/agents/impala/impala.py
… some code that needs to be deleted here, and some long running benchmarks that need to be run, but its looking good.
…la_training_iteration_fn # Conflicts: # rllib/utils/replay_buffers/mixin_replay_buffer.py
…sult dictionaries
…led from number of replay actors:
…la_training_iteration_fn
…to impala_training_iteration_fn
…la_training_iteration_fn
…la_training_iteration_fn
6 tasks
…la_training_iteration_fn
…to impala_training_iteration_fn
…to impala_training_iteration_fn
…la_training_iteration_fn
…la_training_iteration_fn
…la_training_iteration_fn
sven1977
approved these changes
May 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really great @avnishn , thanks for doing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPALA: training_iteration() implementation.
closed the last pr because of gh pr checkout issues
Why are these changes needed?
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.