Skip to content

Conversation

avnishn
Copy link
Member

@avnishn avnishn commented Mar 24, 2022

IMPALA: training_iteration() implementation.

closed the last pr because of gh pr checkout issues

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

sven1977 and others added 27 commits January 2, 2022 22:25
…la_training_iteration_fn

# Conflicts:
#	rllib/agents/impala/impala.py
… some code that needs to be deleted here, and some long running benchmarks that need to be run, but its looking good.
…la_training_iteration_fn

# Conflicts:
#	rllib/utils/replay_buffers/mixin_replay_buffer.py
@avnishn avnishn requested a review from maxpumperla as a code owner April 28, 2022 22:35
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really great @avnishn , thanks for doing this!

@sven1977 sven1977 merged commit f2bb6f6 into ray-project:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants