-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update apache arrow to include TensorFlow fix #2345
Conversation
There may be some plasma hashing related issues. We'll see when the tests run. |
#2319 also updates the Arrow commit. Can you take a look? |
Test PASSed. |
Yeah, the changes in the two PRs are mostly orthogonal (except updating the hash of course); this one is mainly incorporating the plasma API changes and the other one doesn't include that commit. |
Test FAILed. |
Test PASSed. |
@guoyuhong Yeah, I started the PR before yours got merged; I'll probably update it before this PR gets merged, but before that happens, I first need to fix the non-determinism problem. |
thirdparty/scripts/build_arrow.sh
Outdated
@@ -88,7 +88,8 @@ if [[ ! -d $TP_DIR/../python/ray/pyarrow_files/pyarrow || \ | |||
-DARROW_PYTHON=on \ | |||
-DARROW_PLASMA=on \ | |||
-DPLASMA_PYTHON=on \ | |||
-DARROW_JEMALLOC=off \ | |||
-DARROW_JEMALLOC=on \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably won't change anything, but we should test to see if this has any performance implications.
Test FAILed. |
Test FAILed. |
Test FAILed. |
Test FAILed. |
git checkout ce23c06469de9cf0c3e38e35cdb8d135f341b964 | ||
git checkout d5d39f770047d671e4879369dd680c69afc370c3 | ||
|
||
git apply $TP_DIR/scripts/arrow-zero-fill.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone want to update the arrow package, will this patch break the building process?
FYI. My PR which Robert mentioned is used to solve the parquet building error and make it friendly when we update the Arrow package. |
@guoyuhong The patch is just a stop gap solution we are using until apache/arrow#2216 is fixed (hopefully soon, but it's hard to tell and we would like to get a release candidate for 0.5 really soon so we can start the testing), then this patch will go away again. It should be independent of your PR. |
Test FAILed. |
retest this please |
Performance implications: Without this PR:
With this PR:
|
Test PASSed. |
Test failures seem unrelated (due to a Travis rebasing issue I think). |
This is intended to fix #2159.