Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Plasma starting failure when specify the memory in float value. #2337

Merged
merged 6 commits into from
Jul 4, 2018

Conversation

guoyuhong
Copy link
Contributor

What do these changes do?

When we set a float value to object_store_memory to do ray.init(object_store_memory=XXX), Plasma store won't start. We need to guarantee that object_store_memory is an integer.

Related issue number

2333

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6421/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6424/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6423/
Test PASSed.

@robertnishihara
Copy link
Collaborator

Instead of modifying worker.py, I think it makes more sense to raise an exception in

def start_plasma_store(plasma_store_memory=DEFAULT_PLASMA_STORE_MEMORY,

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6439/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6453/
Test FAILed.

@guoyuhong guoyuhong force-pushed the fixPlasmaStartingBug branch from 14c952d to 8d6f111 Compare July 4, 2018 06:30
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6458/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6461/
Test PASSed.

@robertnishihara robertnishihara merged commit 1d51e57 into ray-project:master Jul 4, 2018
@guoyuhong
Copy link
Contributor Author

Thanks, @robertnishihara .

@guoyuhong guoyuhong deleted the fixPlasmaStartingBug branch July 16, 2018 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants