Skip to content

Conversation

heyucongtom
Copy link
Contributor

What do these changes do?

Basically a re-implementation of #2281, with modifications of #2298.
[+] Implement sharding for gcs tables.
[+] Keep ClientTable and ErrorTable managed by the primary_shard. TaskTable is managed by the primary_shard for now, until a good hashing for tasks is implemented.
[+] Move AsyncGcsClient's initialization into Connect function.
[-] Move GetRedisShard and bool sharding from RedisContext's connect into AsyncGcsClient. This may make the interface cleaner.

Please help review the changes and let me know if anything looks problematic.

Related issue number

@heyucongtom heyucongtom changed the title Implementing Gcs sharding after putting Gcs data into redis data shard [WIP] Implementing Gcs sharding after putting Gcs data into redis data shard Jul 1, 2018
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6413/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6417/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6419/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6422/
Test PASSed.

Yucong He added 2 commits July 3, 2018 01:58
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6443/
Test FAILed.

Yucong He added 2 commits July 3, 2018 12:18
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6445/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6446/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6454/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6455/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6457/
Test PASSed.

@robertnishihara
Copy link
Collaborator

@heyucongtom I think some unwanted changes got into this PR (perhaps through some rebasing). Now that #2298 has been merged, I think this PR can be simplified a bit.

@heyucongtom
Copy link
Contributor Author

heyucongtom commented Jul 5, 2018 via email

@robertnishihara
Copy link
Collaborator

E.g., all of the #if !RAY_USE_NEW_GCS changes. The addition of the GetRedisShards function.

@heyucongtom
Copy link
Contributor Author

heyucongtom commented Jul 5, 2018 via email

@heyucongtom heyucongtom deleted the gcs_sharding branch July 17, 2018 02:03
@heyucongtom heyucongtom restored the gcs_sharding branch July 17, 2018 02:03
robertnishihara pushed a commit that referenced this pull request Aug 31, 2018
Basically a re-implementation of #2281, with modifications of #2298 (A fix of #2334, for rebasing issues.).
[+] Implement sharding for gcs tables.
[+] Keep ClientTable and ErrorTable managed by the primary_shard. TaskTable is managed by the primary_shard for now, until a good hashing for tasks is implemented.
[+] Move AsyncGcsClient's initialization into Connect function.
[-] Move GetRedisShard and bool sharding from RedisContext's connect into AsyncGcsClient. This may make the interface cleaner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants