Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nightly test] Fix additional k8s issues + add new tests #23231

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

rkooo567
Copy link
Contributor

Why are these changes needed?

  • Fix bug from the previous fixes.
  • Add more tests
  • Stop using m5.xlarge (not supported now)

There are 2 hard blockers from the infra: 1. Large size disk is not supported. 2. m5.xlarge is not supported. Both are considered as a high priority to be fixed soon.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rkooo567 rkooo567 requested a review from jjyao as a code owner March 16, 2022 15:58
@rkooo567 rkooo567 changed the title [Nightly test] Fix additional k8s issues [Nightly test] Fix additional k8s issues + add new tests Mar 16, 2022
type: job
file_manager: job

- name: k8s_placement_group_performance_test
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are they stable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Good point Let me fix

@rkooo567 rkooo567 merged commit b350fe9 into ray-project:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants