Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 2222] Provide better API method for dumping the task timeline … #2309

Closed
wants to merge 1 commit into from

Conversation

surehb
Copy link
Contributor

@surehb surehb commented Jun 27, 2018

What do these changes do?

Provide better API method for dumping the task timeline

Related issue number

2222

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6307/
Test FAILed.

@surehb
Copy link
Contributor Author

surehb commented Jun 29, 2018

@robertnishihara, @richardliaw , can you please approve it? Thanks!

@robertnishihara
Copy link
Collaborator

Hi @surehb, I've been doing some work recently on improving the timeline visualization (for the raylet code path) in #2306. One thing that I wanted to do was to have a single command for dumping the timeline as an html file, which could be loaded in a browser (by doing something similar to what you do in this PR). However, it seems to me that the HTML file that is dumped when you do this can't actually be loaded in a browser (it seems to only work when embedded in a Jupyter notebook). Is that your experience here? Or do you find that it can be opened in Chrome successfully?

@surehb
Copy link
Contributor Author

surehb commented Jul 2, 2018

@robertnishihara, I haven't tried that yet. Since this is just an interface chance, can we merge this in and do other fix inside the html context if need?

@robertnishihara
Copy link
Collaborator

Thanks @surehb, I was confused. I thought it was dumping an HTML but it's actually dumping a JSON, which should work. Can you fix the linting errors?

@robertnishihara
Copy link
Collaborator

Done with the new backend via ray.global_state.chrome_tracing_dump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants