-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Support local py_modules in jobs #22843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support local py_modules in jobs #22843
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, it's basically what I suggested on the other PR a few minutes ago :)
I think we should take it a step further and do the same for working_dir.
Also, it seems to me that the callback should simply take a local zip file (or bytes?) and return a URI rather than needing to implement its own handling for include_parent_dir
and excludes
.
@edoakes I agree that should be the final state. How about we merge this first, and then I make a followup issue for that refactor? I can also try to do it in #22368, since I need to support uploading local files/bytes anyway for that one. |
|
@architkulkarni merge conflict from @shrekris-anyscale revert and subsequent revert-revert :( |
tests:test_actor_client_mode, Windows tests:test_basic_2_client_mode, and doc build (concurrency limit) broken on master. Mac builds are stalled on master |
Why are these changes needed?
Related issue number
Previously local py_modules were not uploaded to the remote cluster during job submission, so jobs could only use py_modules from remote URIs. This PR uploads py_modules to the cluster, just like how it currently works for the non job-submission case.
Checks
scripts/format.sh
to lint the changes in this PR.