Skip to content

Conversation

architkulkarni
Copy link
Contributor

@architkulkarni architkulkarni commented Mar 6, 2022

Why are these changes needed?

Related issue number

Previously local py_modules were not uploaded to the remote cluster during job submission, so jobs could only use py_modules from remote URIs. This PR uploads py_modules to the cluster, just like how it currently works for the non job-submission case.

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@architkulkarni architkulkarni changed the title [wip] support local py_modules in jobs Support local py_modules in jobs Mar 7, 2022
Copy link
Collaborator

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, it's basically what I suggested on the other PR a few minutes ago :)

I think we should take it a step further and do the same for working_dir.

Also, it seems to me that the callback should simply take a local zip file (or bytes?) and return a URI rather than needing to implement its own handling for include_parent_dir and excludes.

@edoakes edoakes added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Mar 7, 2022
@architkulkarni
Copy link
Contributor Author

Also, it seems to me that the callback should simply take a local zip file (or bytes?) and return a URI rather than needing to implement its own handling for include_parent_dir and excludes.

@edoakes I agree that should be the final state. How about we merge this first, and then I make a followup issue for that refactor? I can also try to do it in #22368, since I need to support uploading local files/bytes anyway for that one.

@architkulkarni architkulkarni removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Mar 9, 2022
@edoakes edoakes added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Mar 9, 2022
@architkulkarni architkulkarni added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels Mar 9, 2022
@architkulkarni
Copy link
Contributor Author

serve:test_cli is flaky on master.

@edoakes
Copy link
Collaborator

edoakes commented Mar 10, 2022

@architkulkarni merge conflict from @shrekris-anyscale revert and subsequent revert-revert :(

@architkulkarni
Copy link
Contributor Author

tests:test_actor_client_mode, Windows tests:test_basic_2_client_mode, and doc build (concurrency limit) broken on master. Mac builds are stalled on master

@edoakes edoakes merged commit c78bd80 into ray-project:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants